Skip to content

use more collection expressions and mark as error in editorconfig #5377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jun 2, 2025
Merged

use more collection expressions and mark as error in editorconfig #5377

merged 16 commits into from
Jun 2, 2025

Conversation

SimonCropp
Copy link
Contributor

No description provided.

@SimonCropp
Copy link
Contributor Author

should i go to the effort of resolving the conflicts?

@nohwnd
Copy link
Member

nohwnd commented Apr 14, 2025

I don't have a strong opinion on using [] or not. @Youssef1313 how about you ?

@Youssef1313
Copy link
Member

Fine for me as well. But I'd enable it via the IDE030x rules which will be applicable to command-line, instead of Rider rule.

https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0300
https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0301
https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0302
https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0303
https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0304
https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0305
https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0306

@SimonCropp
Copy link
Contributor Author

@Youssef1313 done

@Evangelink Evangelink enabled auto-merge (squash) May 12, 2025 08:36
Evangelink
Evangelink previously approved these changes May 12, 2025
View reviewed changes
@SimonCropp SimonCropp changed the title use more collection expressions and mark as error for Rider and R# in editorconfig use more collection expressions and mark as error in editorconfig May 12, 2025
@Evangelink Evangelink merged commit 721ac32 into microsoft:main Jun 2, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evangelink Evangelink Evangelink approved these changes

@Youssef1313 Youssef1313 Awaiting requested review from Youssef1313

@nohwnd nohwnd Awaiting requested review from nohwnd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SimonCropp @nohwnd @Youssef1313 @Evangelink